DEGA-279-numerical-attributes

[cornhundred]

No description provided.

[Copilot]

Pull Request Overview

This PR refactors metadata handling to support mixed numeric and categorical attributes, deprecates legacy JSON/network parameters, and enhances widget cleanup and deprecation warnings across Python and JavaScript.

• Rename col_cats/row_cats to col_attr/row_attr and implement add_mixed_attributes_to_node_info.
• Introduce deprecation warnings for JSON export methods and the legacy network widget parameter.
• Add close() cleanup hooks in widget classes and update JS to finalize deck instances.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/celldega/clust/matrix.py	Renamed category parameters, added mixed attribute logic
src/celldega/clust/utils.py	Added add_mixed_attributes_to_node_info helper
src/celldega/viz/widget.py	Added close() methods and deprecation warnings
tests/unit/test_clust/test_matrix.py	Updated signature and added numeric attribute test
js/widget.js	Refactored render cleanup, removed legacy network init
js/viz/matrix_viz.js	Routed all category layers through new set_cat_data
js/matrix/set_constants.js	Replaced category counts with attribute-based counts
js/matrix/cat_data.js	Unified categorical & numeric attribute rendering

Comments suppressed due to low confidence (3)

tests/unit/test_clust/test_matrix.py:366

• [nitpick] This test covers numeric row attributes but doesn’t verify column attributes. Add assertions for col_attr keys in mat.viz and numeric data in col_nodes to ensure full coverage.

    def test_numeric_attributes_in_viz(self) -> None:

js/widget.js:121

• Removing the fallback assignment for network means network will be undefined if mat_parquet is not provided. Introduce a fallback, e.g., network = model.get('network').

  // let network = model.get('network');

js/widget.js:184

• The render function no longer returns the cleanup callback at the end. Add return cleanup; after the message handler so the widget can be finalized properly.

    });

[cornhundred]

You can test the numerical attribute in this notebook notebooks/Clustergram_Example.ipynb

[jaspreetishar]

LGTM - the Clustergram_Example notebook runs fine, and all unit tests are passing