fix: Do not use default parameter values for ie https://github.com/brix/crypto-js/pull/357 #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trmpowell
reviewed
Aug 17, 2021
src/enc-base64url.js
Outdated
| // Shortcuts | ||
| var words = wordArray.words; | ||
| var sigBytes = wordArray.sigBytes; | ||
| var map = urlSafe ? this._safe_map : this._map; | ||
| var map = urlSafe === undefined ? this._map : this._safe_map; |
There was a problem hiding this comment.
I think you want
var map = urlSafe === undefined || urlSafe ? this._safe_map : this._map;
If urlSafe is undefined, you want this to default to true, so you want to use the _safe_map scenario. Or perhaps I'm missing something?
There was a problem hiding this comment.
If you use babel, you will find that the default value of the function parameter only needs to judge undefined.
There was a problem hiding this comment.
emmm...you are right, but i think maybe this way will be better?
var map = urlSafe ? this._safe_map : this._map;
|
Already solved, but not released yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed this pr: https://github.com/brix/crypto-js/pull/357，and use this pr to fix it.