Make console logs more accessible during Playwright e2e test runs #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrz
commented
May 3, 2024
Comment on lines
+15
to
+17
| // Ensure all console logs go through electron-log | ||
| console.log = log.log | ||
|
|
There was a problem hiding this comment.
This change caused the console.log() messages I'd added in packages/zed-node/src/lake.ts to show up in the packages/zui-player/run/playwright-itest/Pool Loads (succeeses)/1/logs/main.log.
philrz
commented
May 3, 2024
Comment on lines
+48
to
+52
| // Pipe the stdout from the electron process into the test runner process | ||
| if (process.env['VERBOSE']) { | ||
| this.zui.process().stdout.pipe(process.stdout); | ||
| } | ||
|
|
There was a problem hiding this comment.
If I run my tests via VERBOSE=1 yarn e2e, this change caused the console.log() messages I'd added in packages/zed-node/src/lake.ts to also show up in the shell window from which I ran yarn e2e.
jameskerr
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While starting to debug #3063, I tried adding some
console.log()debug statements topackages/zed-node/src/lake.ts, but the messages weren't visible in the shell window from which I ranyarn e2enor in thepackages/zui-player/run/playwright-itest/Pool Loads (succeeses)/1/logs/main.log. @jameskerr hacked at this with me a bit over Zoom and came up with these two improvements that make the messages show up in both locations. I'll put comments inline that explain which does what.