Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Rework datapoint #25

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

[WIP] Rework datapoint #25

wants to merge 16 commits into from

Conversation

briederer
Copy link
Owner

@briederer briederer commented Oct 28, 2021 •
edited
Loading

After some struggles and adaptions to the DataPoint struct I've decided that it is better to rework it completely.
However the other PR #23 is now obsolete.

@briederer briederer added enhancement New feature or request WIP Work in progress labels Oct 28, 2021
@briederer briederer mentioned this pull request Oct 28, 2021
Closed
@briederer
Copy link
Owner Author

Currently tests are failing.
Will fix these when I am happy with the general structure of our datatype.

@github-actions
Copy link
Contributor

The Docs for this PR are deployed! 🥳
You can find them here.

Please make sure that you have documented your new feature properly:

  • Added documentation (if needed).

@briederer briederer marked this pull request as draft October 28, 2021 07:29
@briederer
Copy link
Owner Author

briederer commented Nov 4, 2021 •
edited
Loading

Still missing:

  • Adaption of printing
  • Further docs
  • Tests for recipes
  • Tests for printing
  • Tests for overloaded functions
  • Tests for macro

@briederer briederer mentioned this pull request Nov 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@briederer