fix(arm): Fix resource ID generation to use variables #6884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omriyoffe-panw
temporarily deployed
to
scan-security
GitHub Actions
Inactive
lirshindalman
approved these changes
Dec 2, 2024
bo156
reviewed
Dec 2, 2024
| @@ -273,7 +273,7 @@ def add_graph_check_results(self, report: Report, runner_filter: RunnerFilter) - | |||
| file_path=self.extract_file_path_from_abs_path(clean_file_path(Path(entity_file_path))), | |||
| file_abs_path=str(file_abs_path), | |||
| file_line_range=[start_line - 1, end_line - 1], | |||
| resource_id=entity[CustomAttributes.ID], | |||
| resource_id=f'{entity[CustomAttributes.RESOURCE_TYPE]}.{entity[CustomAttributes.BLOCK_NAME]}', | |||
There was a problem hiding this comment.
any reason not to use CustomAttributes.RESOURCE_ID?
bo156
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Fix the
resource_idgeneration incheckov/arm/runner.pyto use variables forRESOURCE_TYPEandBLOCK_NAME, improving logging and error handling.resource_idgeneration by usingRESOURCE_TYPEandBLOCK_NAMEvariables.Modified files (1)
Latest Contributors(2)
RESOURCE_TYPEorBLOCK_NAMEin entities.Modified files (1)
Latest Contributors(2)