Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets): fix find line #6864

Merged
merged 2 commits into from
Nov 21, 2024
Merged

fix(secrets): fix find line #6864

merged 2 commits into from
Nov 21, 2024

Conversation

omryMen
Copy link
Contributor

@omryMen omryMen commented Nov 21, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Refactor the CustomRegexDetector class to improve the accuracy of line number detection for potential secrets. Introduce error handling in the find_line_number function to ensure robustness against unexpected input.

TopicDetails
Error Handling Enhance error handling in find_line_number.
Modified files (1)
  • checkov/secrets/plugins/custom_regex_detector.py
Latest Contributors(2)
UserCommitDate
RabeaZrfix-secrets-multiline-...November 21, 2024
omryMenfix-secrets-skip-empty...November 18, 2024
Line Number Fix Improve line number detection in CustomRegexDetector.
Modified files (1)
  • checkov/secrets/plugins/custom_regex_detector.py
Latest Contributors(2)
UserCommitDate
RabeaZrfix-secrets-multiline-...November 21, 2024
omryMenfix-secrets-skip-empty...November 18, 2024
This pull request is reviewed by Baz. Join @omryMen and the rest of your team on (Baz).

@omryMen omryMen merged commit cb1aaac into main Nov 21, 2024
42 checks passed
@omryMen omryMen deleted the fix-find-line branch November 21, 2024 12:36
Saarett pushed a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants