fix(terraform): Update CKV_AZURE_164 to correct check on trust policy #6757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddymorgan84
had a problem deploying
to
scan-security
GitHub Actions
Failure
paddymorgan84
had a problem deploying
to
scan-security
GitHub Actions
Failure
paddymorgan84
had a problem deploying
to
scan-security
GitHub Actions
Failure
paddymorgan84
had a problem deploying
to
scan-security
GitHub Actions
Failure
Saarett
temporarily deployed
to
scan-security
GitHub Actions
Inactive
SteveVaknin
changed the title
paddymorgan84
force-pushed
the
trust-policy
branch
from
2fa176d to
8f1ad05
Compare
paddymorgan84
had a problem deploying
to
scan-security
GitHub Actions
Failure
tsmithv11
requested changes
Nov 14, 2024
paddymorgan84
force-pushed
the
trust-policy
branch
from
8f1ad05 to
0003b05
Compare
paddymorgan84
had a problem deploying
to
scan-security
GitHub Actions
Failure
paddymorgan84
force-pushed
the
trust-policy
branch
from
0003b05 to
0b934b0
Compare
paddymorgan84
had a problem deploying
to
scan-security
GitHub Actions
Failure
paddymorgan84
force-pushed
the
trust-policy
branch
from
0b934b0 to
1ddc597
Compare
paddymorgan84
had a problem deploying
to
scan-security
GitHub Actions
Failure
paddymorgan84
force-pushed
the
trust-policy
branch
from
1ddc597 to
d3ac2b0
Compare
paddymorgan84
had a problem deploying
to
scan-security
GitHub Actions
Failure
|
Changes should be ready @tsmithv11, including the linting I missed from the previous PR. I've also raised a PR in |
paddymorgan84
force-pushed
the
trust-policy
branch
from
d3ac2b0 to
32ce54c
Compare
paddymorgan84
had a problem deploying
to
scan-security
GitHub Actions
Failure
tsmithv11
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Why did you modify this file? Looks unrelated
There was a problem hiding this comment.
I did a quick search on where else trust_policy was used and thought it would be worth updating others to match the latest version too. I can remove if this isn't preferable
There was a problem hiding this comment.
It's not necessary, but since the check associated with that file doesn't look at that field, it shouldn't matter. I'll trigger the UTs to confirm.
tsmithv11
approved these changes
Nov 21, 2024
paddymorgan84
force-pushed
the
trust-policy
branch
from
32ce54c to
293180f
Compare
paddymorgan84
had a problem deploying
to
scan-security
GitHub Actions
Failure
paddymorgan84
force-pushed
the
trust-policy
branch
from
293180f to
3420118
Compare
paddymorgan84
had a problem deploying
to
scan-security
GitHub Actions
Failure
paddymorgan84
force-pushed
the
trust-policy
branch
from
3420118 to
00b4fea
Compare
paddymorgan84
had a problem deploying
to
scan-security
GitHub Actions
Failure
|
@tsmithv11 Any suggestions for someone else to review this for me so it's good to merge? |
paddymorgan84
force-pushed
the
trust-policy
branch
from
00b4fea to
3dd58a7
Compare
paddymorgan84
had a problem deploying
to
scan-security
GitHub Actions
Failure
paddymorgan84
force-pushed
the
trust-policy
branch
from
3dd58a7 to
01f3513
Compare
paddymorgan84
had a problem deploying
to
scan-security
GitHub Actions
Failure
tsmithv11
had a problem deploying
to
scan-security
GitHub Actions
Failure
Saarett
pushed a commit
that referenced
this pull request
Nov 27, 2024
…#6757) fix: Update CKV_AZURE_164 to correct check on trust policy Co-authored-by: Taylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Update the
ACRUseSignedImagesclass to correct the trust policy check for Azure Container Registries. Modify thescan_resource_confmethod to accurately evaluate thetrust_policy_enabledandtrust_policy/enabledkeys, ensuring that the check passes only when the trust policy is enabled. Adjust the test cases intest_ACRUseSignedImages.pyto reflect these changes, ensuring that both new and old configurations are tested for compliance.Modified files (3)
Latest Contributors(2)
ACRUseSignedImagesto ensure accurate evaluation of Azure Container Registry configurations.Modified files (1)
Latest Contributors(2)