verify_cert: check name constraints after sig. validation #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit parsing and processing certificate name constraints was done before validating a chain of signatures to a known trust anchor. This increases the attack surface of these features, allowing an adversary to force webpki to process name constraints on a crafted certificate without needing to have that certificate issued by a trusted entity. This commit moves the parsing and processing of name constraints to after building and verifying the chain of signatures to reduce the potential for mischief.
Codecov Report
@@ Coverage Diff @@
## main #278 +/- ##
==========================================
+ Coverage 50.62% 50.86% +0.23%
==========================================
Files 18 18
Lines 3751 3769 +18
==========================================
+ Hits 1899 1917 +18
Misses 1852 1852
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Two things here:
|
|
Thanks! I rebased this on main in #280 so I could merge it. I'm closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this branch parsing and processing certificate name constraints was done before validating a chain of signatures to a known trust anchor. This increases the attack surface of these features, allowing an adversary to force webpki to process name constraints on a crafted certificate without needing to have that certificate issued by a trusted entity.
This branch moves the parsing and processing of name constraints to after building and verifying the chain of signatures to reduce the potential for mischief. It's a backport of part of the work from rustls/webpki#165, however test coverage and constraining the number of comparisons using a budget limit are omitted due to the general state of name constraint support (c.f. #226).