Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo.toml not updated to 0.21.4 #150

Closed
olix0r opened this issue Dec 7, 2020 · 0 comments · Fixed by #151
Closed

Cargo.toml not updated to 0.21.4 #150

olix0r opened this issue Dec 7, 2020 · 0 comments · Fixed by #151

Comments

@olix0r
Copy link

olix0r commented Dec 7, 2020

Last week 0.21.4 was published to crates, but Git's Cargo.toml still specifies 0.21.3:

webpki/Cargo.toml

Line 25 in 2d32895

version = "0.21.3"

I'm assuming the commit with the version bump wasn't pushed to origin? I can submit a PR if it would be helpful, but I assume the change is already made somewhere.

This creates problems for projects that have Git dependencies -- we're using a branch that includes the changes #91, though we've been merging changes from master as well.
hawkw added a commit to hawkw/webpki that referenced this issue Dec 7, 2020
@hawkw
Bump Cargo.toml version to 0.21.4
6312d22 
Upstream [has released version 0.21.4 to crates.io][1] but the
`Cargo.toml` version in the repository [hasn't been updated][2].
However, `rustls` now depends on ^0.21.4 on its `main` branch, so a git
dependency on the latest `rustls` doesn't compile with our fork.

This commit updates the `Cargo.toml` version to 0.21.4 to match
upstream.

See also briansmith#150

[1]: https://crates.io/crates/webpki/0.21.4
[2]: https://github.com/briansmith/webpki/blob/2d32895b609ac3594bcdd75d6e97c78f4f184167/Cargo.toml#L25

Signed-off-by: Eliza Weisman <[email protected]>
@hawkw hawkw mentioned this issue Dec 7, 2020
Closed
@briansmith briansmith linked a pull request Dec 7, 2020 that will close this issue
0.21.4. #151
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

0.21.4. briansmith/webpki
1 participant
@olix0r