Use BoringSSL's aes_nohw.c fallback AES implementation. #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relands https://boringssl-review.googlesource.com/c/boringssl/+/39206. See that CL description for details on the change. The CL was originally reverted due to a number of ARM-only test failures. First, there was a test-only issue, resolved in https://boringssl-review.googlesource.com/c/boringssl/+/39306. Second, the implementation did not work in unoptimized Android Thumb2 builds. This was caused by a clang bug introduced in https://reviews.llvm.org/rL340261 and fixed in https://reviews.llvm.org/rL351310. aes_nohw_(un)compact_block have been rewritten in an attempt to dodge the bug. Performance of optimized builds with clang and gcc do not appear to be affected by the rewrite. See the delta from patch set 1. (I had hoped to improve precommit CQ coverage before landing this, but both failures turned out to be ARM-only. Either way, there are now 32-bit and 64-bit SSE2-less configurations so the 32-bit and 64-bit implementations have CQ coverage.) Change-Id: If5f9f5ea570686a15258ecd7cf49bdbc12dc34c5 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/39444 Reviewed-by: Adam Langley <[email protected]>
Add the BoringSSL aes_nohw implementation with minimal changes needed to build. Enable the AES-GCM AEAD tests for wasm32 targets gated on the "wasm_c" feature.
briansmith
force-pushed
the
b/merge-boringssl-aes-nohw-c
branch
from
2486ec3 to
0d5ab53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for AES for platforms that don't have assembly languages implementations. Remove the remaining data-timing-dependent assembly language implementations. Add support for using (and testing) AES-GCM in WebAssembly.