Adds test case #466
Adds test case #466
Conversation
|
I made a mistake while committing and included changes from another pull request. I will revert them and we can squash the commits when merging. |
src/pbkdf2.rs
Outdated
| let iterations = 0; | ||
| let salt = "salt".as_bytes(); | ||
| let mut out = vec![0u8; 2]; | ||
| pbkdf2::derive(prf, iterations as u32, &salt, &secret, &mut out); |
There was a problem hiding this comment.
Thanks!
NIT: don't use as u32 here. If you need a type annotation then use let iterations: u32 = 0; instead.
Also, please make a variant of the test that has all the parameters the same, except iterations == 1, and which doesn't panic, to help demonstrate that iterations == 0 is the reason for the panic. Add a comment to the control test like “// Control for pkbdf2_zero_iterations().”
Please add the contributor's statement to the end of your commit message; see https://github.com/briansmith/ring#contributing.
If you know how, please rebase this on master without the ASAN changes, e.g. using git rebase -i master and moving this commit to the top of the list. If you don't know how to do that, don't worry about it; I'll do it when I land the change.
Adds a test case for pbkdf2 where iterations == 0. I agree to license my contributions to each file under the terms given at the top of each file I changed.
|
Changes Unknown when pulling ac7bb7b on joshuata:23_Adds_test_casses into ** on briansmith:master**. |
|
Thanks! This landed as b141727. |
Closes #23