chacha: Reduce API surface for Counter/IV management. #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the `pub(super)` IV/Counter API with a simpler, private one. This makes it clearer that the callers are handling nonces correctly. This will also make it easier to refactor the Counter handling later.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2233 +/- ##
==========================================
- Coverage 97.00% 96.94% -0.07%
==========================================
Files 165 165
Lines 20506 20508 +2
Branches 464 465 +1
==========================================
- Hits 19892 19881 -11
- Misses 505 517 +12
- Partials 109 110 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
pub(super)IV/Counter API with a simpler, private one.This makes it clearer that the callers are handling nonces correctly. This will also make it easier to refactor the Counter handling later.