Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling: Refactor how "Input too long" errors are handled. #2202

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

briansmith
Copy link
Owner

Handle "input too long" errors consistently across the digest and bits modules. This is a step towards more modules doing the same.

@briansmith briansmith self-assigned this Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 97.16%. Comparing base (0a00284) to head (e43a335).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/tests/bits_tests.rs 84.21% 3 Missing ⚠️
src/digest.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2202      +/-   ##
==========================================
- Coverage   97.18%   97.16%   -0.02%     
==========================================
  Files         156      158       +2     
  Lines       20217    20232      +15     
  Branches      454      454              
==========================================
+ Hits        19647    19658      +11     
- Misses        465      470       +5     
+ Partials      105      104       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briansmith briansmith force-pushed the b/gcm-error-2 branch 4 times, most recently from ba79cc0 to 9a3fa6e Compare December 30, 2024 05:41
Handle "input too long" errors consistently across the `digest` and
`bits` modules. This is a step towards more modules doing the same.
@briansmith briansmith merged commit cb1d1ae into main Dec 31, 2024
156 of 158 checks passed
@briansmith briansmith deleted the b/gcm-error-2 branch December 31, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant