Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signature: Enable Ed25519 support for wasm32 targets. #1440

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

briansmith
Copy link
Owner

Ed25519 was disabled for WebAssembly due to some unrelated issues with
getting the X25519 code working in WebAssembly. Temporarily remove the
agreement API when targetting WebAssembly to work around those issues
in a way that lets us enabled Ed25519.

Ed25519 was disabled for WebAssembly due to some unrelated issues with
getting the X25519 code working in WebAssembly. Temporarily remove the
`agreement` API when targetting WebAssembly to work around those issues
in a way that lets us enabled Ed25519.
@briansmith briansmith self-assigned this Dec 15, 2021
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #1440 (80a5c0d) into main (08fcf4a) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1440   +/-   ##
=======================================
  Coverage   93.02%   93.03%           
=======================================
  Files         127      127           
  Lines       18227    18227           
  Branches      195      195           
=======================================
+ Hits        16956    16957    +1     
  Misses       1237     1237           
+ Partials       34       33    -1     
Impacted Files Coverage Δ
src/ec.rs 100.00% <ø> (ø)
src/ec/keys.rs 96.42% <ø> (ø)
src/ec/suite_b.rs 98.65% <ø> (ø)
src/lib.rs 93.33% <ø> (ø)
tests/agreement_tests.rs 90.74% <ø> (ø)
tests/ed25519_tests.rs 97.79% <ø> (ø)
crypto/curve25519/curve25519.c 99.77% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08fcf4a...80a5c0d. Read the comment docs.

@ivnsch
Copy link

ivnsch commented Feb 28, 2022

Any updates? We're using this in an SDK https://github.com/manuelmauro/algonaut/blob/main/algonaut_transaction/src/account.rs#L35 and it would be great if it didn't break WASM compatibility..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants