Repository navigation
Pin Node to 24.20.0 everywhere - #200
Merged
Merged
Conversation
Was floating on the 24.x major (>=24 engine range, unpinned Dockerfile/CI tags), which let the Node 24.20 ace loader regression (#199) reach prod undetected until it broke tests. Pin package.json engines, .nvmrc, docker/Dockerfile, docker/dev.Dockerfile, and both CI node-version fields to the same exact version. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
Previous Review Summary (commit 0f94437)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 0f94437)Status: 1 Issue Found | Recommendation: Merge (1 non-blocking suggestion) Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (7 files)
Reviewed by deepseek-v4-pro-0813 · Input: 24.6K · Output: 3.1K · Cached: 178K Review guidance: REVIEW.md from base branch |
Exact-pinning engines.node warns (and hard-fails under apps/web/.npmrc's engine-strict=true) on every future patch release. The actual reproducible pin lives in .nvmrc/Docker/CI already; engines should just express the minimum supported version. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
24.20.0patch acrosspackage.json(engines.node),.nvmrc,docker/Dockerfile,docker/dev.Dockerfile, and both GitHub Actions Node setup points (.github/actions/setup/action.yml,.github/workflows/native-build.yml), instead of a floating>=24/node:24/node-version: 24.aceloader regression reached CI/prod undetected because nothing in the repo pinned an exact Node version — this is the scaffolding-stage guardrail that was missing.Test plan
node:24.20.0-bookworm-slimexists on Docker Hub🤖 Generated with Claude Code