When 'logpost' is set, also ensure request method is POST and body is…

… not empty.
briannesbitt · Apr 25, 2012 · cb1344d · cb1344d
1 parent b848ac3
commit cb1344d
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/src/play/modules/accesslog/AccessLogPlugin.java b/src/play/modules/accesslog/AccessLogPlugin.java
@@ -130,9 +130,19 @@ private synchronized void log()
       line = StringUtils.replaceOnce(line, "%ua", (userAgent != null) ? userAgent.value() : "");
       line = StringUtils.replaceOnce(line, "%rt", String.valueOf(requestProcessingTime));
 
-      if (_shouldLogPost)
+      if (_shouldLogPost && request.method.equals("POST"))
       {
-         line = StringUtils.replaceOnce(line, "%post", request.params.get("body"));
+         String body = request.params.get("body");
+
+         if (StringUtils.isNotEmpty(body))
+         {
+            line = StringUtils.replaceOnce(line, "%post", body);
+         }
+         else
+         {
+            // leave quotes in the logged string to show it was an empty POST request
+            line = StringUtils.remove(line, "%post");
+         }
       }
       else
       {