Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate en to fr #11

Merged
merged 5 commits into from
Jan 2, 2017
Merged

translate en to fr #11

merged 5 commits into from
Jan 2, 2017

Conversation

bnoufel
Copy link
Contributor

@bnoufel bnoufel commented Dec 22, 2016

It's done

@@ -598,7 +630,7 @@
CODE_SIGN_IDENTITY = "Mac Developer";
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 529;
DEVELOPMENT_TEAM = YN24FFRTC8;
DEVELOPMENT_TEAM = A925WRGBAZ;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't accept these changes to the development team, sorry it need so to continue to be the old development team.

Copy link
Owner

@brianmichel brianmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything besides the code signing changes and preferences xib location looks great! Fix those things up and we should be good to go.

AA66D55B1E0C77F700D83161 /* fr */,
);
name = GeneralPreferencesViewController.xib;
path = ../../.Trash/Juice/Classes;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path seems wrong, should this be pointing to the file located within the project?

@brianmichel
Copy link
Owner

With this patch applied the project does not compile
screen shot 2016-12-23 at 9 09 38 am

@bnoufel
Copy link
Contributor Author

bnoufel commented Dec 24, 2016

Merry Chrismas

I have a problem with encodage to pbproject i resolved that tomorow :)

@brianmichel
Copy link
Owner

@flayor this still has the development team changes in the project file.

@brianmichel
Copy link
Owner

@flayor hey sorry for not looking at this sooner I've been busy with work, but I'll take a look at this tomorrow evening but it's looking good!

@bnoufel
Copy link
Contributor Author

bnoufel commented Dec 29, 2016

No problem take your time :)

@brianmichel
Copy link
Owner

Overall I think this looks okay, I'll merge it in and fix up anything that is broken within the master branch. Thanks for the translations!

@brianmichel brianmichel merged commit ee4caec into brianmichel:master Jan 2, 2017
@bnoufel
Copy link
Contributor Author

bnoufel commented Jan 2, 2017

Your welcome ... i continue translate with your update ... just,

for the word "scale" want to tell you "theme" scale in french with the sentence doesn't mean anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants