-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cassandra2-cql driver to only run tests on jdk8 #669
Update cassandra2-cql driver to only run tests on jdk8 #669
Conversation
Looks good to me. Didn't get to test it on JDK 8 though. |
I could add the travis-ci change to test jdk8 now, if it would help? |
👍 sorry @busbey took me a few days to get back to this. |
No worries. Is the thumbs up for merging as-is or for adding the travis-ci change? |
merge. I think the travis ci change should be separate. |
Just as a note: this prints a really "scary" message about sigar on Mac when trying to test with JDK 8. The warning doesn't cause any issues and the tests pass just fine. An example of the message is here:
|
update the work in #614 so that maven skips tests under jdk7 and uses a profile to turn them on under jdk8.