[core] Add a UnixEpochTimestampGenerator #656
Conversation
| @@ -0,0 +1,188 @@ | |||
| /** | |||
| * Copyright (c) 2016 Yahoo! Inc. All rights reserved. | |||
There was a problem hiding this comment.
Instead of Yahoo! Inc. This should be Copyright (c) 2016 YCSB contributors. All rights reserved.
Same goes for the test file.
|
Fixed up the copyrights, thanks! |
|
Would you mind updating the commit message to start with the module impacted? In this case it'd be something like "[core] ..." |
| */ | ||
| public class UnixEpochTimestampGenerator extends Generator<Long> { | ||
| /** Name and default value for the timestamp interval property. */ | ||
| public static final String TIMESTAMP_INTERVAL_PROPERTY = "timestamp_interval"; |
There was a problem hiding this comment.
Where are these properties getting used? What are they for?
There was a problem hiding this comment.
They'll be used by the TimeseriesWorkload class once it's ready. I figured it'd be good to stash them here as they could be used by multiple workloads. Or I could just move them there if you think that's better.
There was a problem hiding this comment.
Other workloads might want to have multiple timestamps, which would then make these properties confusing. Probably best to keep them in the TimeseriesWorkload.
Thanks!
There was a problem hiding this comment.
Sounds good, yanked those guys out and I'll toss 'em in with the TS workload.
|
Commit message updated, thanks! |
[core] Add a UnixEpochTimestampGenerator
|
thanks! |
Tied to generating time series workloads: #653