Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jdbc] Add mssql support for scan operation #1350

Merged
merged 2 commits into from
Sep 8, 2019
Merged

[jdbc] Add mssql support for scan operation #1350

merged 2 commits into from
Sep 8, 2019

Conversation

KowsarAtz
Copy link
Contributor

Fixing the syntax issue SQL Server faced during scan operation.
( Microsoft SQL Server doesn't support LIMIT statement, so I added a condition to use TOP instead when we are using jdbc-binding to benchmark SQL Server scan operation. )

Copy link
Collaborator

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits on copyright years and this should be good to go. Will be best if someone can test mssql for the next release to contain this change

@busbey busbey merged commit fc9f1a2 into brianfrankcooper:master Sep 8, 2019
@busbey busbey mentioned this pull request Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants