Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated driver. #1295

Merged
merged 2 commits into from
Apr 19, 2019
Merged

Removing deprecated driver. #1295

merged 2 commits into from
Apr 19, 2019

Conversation

voellm
Copy link
Contributor

@voellm voellm commented Apr 19, 2019

Tracked in issue #1269

Copy link
Collaborator

@stfeng2 stfeng2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, strictly removal.

@stfeng2 stfeng2 merged commit a90a5a7 into brianfrankcooper:master Apr 19, 2019
@busbey
Copy link
Collaborator

busbey commented Apr 26, 2019

In the future please follow commit message format "[binding] summary of change".

e.g. for this a single commit with the message "[azuredocumentdb] remove Azure DocumentDB binding"

@stfeng2
Copy link
Collaborator

stfeng2 commented Apr 26, 2019

Got it @busbey! Thanks for the reminder! 👍

@busbey busbey mentioned this pull request Jun 4, 2019
@busbey busbey mentioned this pull request Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants