Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tablestore] Add binding for Alibaba Cloud's TableStore #1286

Merged
merged 1 commit into from
Jun 4, 2019
Merged

[tablestore] Add binding for Alibaba Cloud's TableStore #1286

merged 1 commit into from
Jun 4, 2019

Conversation

HoboChen
Copy link
Contributor

  1. TableStore is a NoSQL service provided by Alibaba Cloud. Link
  2. Code, Guide of Howto is provided.

@HoboChen
Copy link
Contributor Author

@busbey hello, could you take a look at this pr?

@HoboChen
Copy link
Contributor Author

@stfeng2 hello?

@busbey
Copy link
Collaborator

busbey commented Apr 16, 2019

Will do. It'll be a bit as I'm loaded up at $dayjob at the moment.

Could you squash your commits and make sure the commit message is something like "[TableStore] added TableStore binding"?

@stfeng2
Copy link
Collaborator

stfeng2 commented Apr 16, 2019 via email

@HoboChen
Copy link
Contributor Author

done, @busbey

@HoboChen
Copy link
Contributor Author

hello？@busbey

@busbey
Copy link
Collaborator

busbey commented Apr 22, 2019

Hi!

YCSB is a volunteer run project. Sometimes reviews take a while. The best way to get your stuff reviewed faster is to find an open PR that's still waiting for feedback and provide a review.

busbey
busbey requested changes Apr 25, 2019
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
tablestore/src/main/java/com/yahoo/ycsb/db/TableStoreClient.java Outdated Show resolved Hide resolved
tablestore/src/main/java/com/yahoo/ycsb/db/TableStoreClient.java Outdated Show resolved Hide resolved
tablestore/src/main/java/com/yahoo/ycsb/db/TableStoreClient.java Outdated Show resolved Hide resolved
tablestore/src/main/java/com/yahoo/ycsb/db/TableStoreClient.java Outdated Show resolved Hide resolved
tablestore/src/main/java/com/yahoo/ycsb/db/TableStoreClient.java Outdated Show resolved Hide resolved
tablestore/src/main/java/com/yahoo/ycsb/db/TableStoreClient.java Outdated Show resolved Hide resolved
tablestore/src/main/java/com/yahoo/ycsb/db/TableStoreClient.java Outdated Show resolved Hide resolved
tablestore/src/main/java/com/yahoo/ycsb/db/package-info.java Outdated Show resolved Hide resolved
tablestore/src/main/java/com/yahoo/ycsb/db/TableStoreClient.java Outdated Show resolved Hide resolved
@HoboChen HoboChen force-pushed the master branch 4 times, most recently from ace2822 to fd20839 Compare May 27, 2019 06:51
@HoboChen
Copy link
Contributor Author

Hi,
I have already resolved all the comments. @busbey Thanks for your time in advance!

@HoboChen
Copy link
Contributor Author

HoboChen commented Jun 3, 2019

As it is recommended to share one client in multi threads, and it is tricky to do the clean up (maintaining a ref count is needed); also, it is OK to let it go ( actually no harm if no client.shutdown() here).
So it is OK here.

Also, I have resolved the variable not used issue.

@busbey
Copy link
Collaborator

busbey commented Jun 3, 2019

The travis failure is #1312 . Would you mind reviewing that PR @HoboChen ?

@busbey
Copy link
Collaborator

busbey commented Jun 3, 2019

#1312 is now merged, so I restarted the Travis build. I'm not sure if it'll skip oracle jdk8 though since you haven't had a chance to rebase. if it does we can just merge since we know that jdk won't be used any more.

@busbey busbey changed the title Add TableStore Binding [tablestore] Add binding for Alibaba Cloud's TableStore Jun 4, 2019
@busbey busbey merged commit d55ac2b into brianfrankcooper:master Jun 4, 2019
@busbey
Copy link
Collaborator

busbey commented Jun 4, 2019

Thanks for getting this done @HoboChen !

I'll ping you when the next release starts to make sure what we release still works as expected.

busbey added a commit to busbey/YCSB that referenced this pull request Jun 4, 2019
@busbey
[core] add missing license headers.
264734d 
* brianfrankcooper#1249 missed headers when moving things out of Client.java
* brianfrankcooper#1242 missed header on a properties file is added
* brianfrankcooper#1286 missed header on the new pom file
@busbey busbey mentioned this pull request Jun 4, 2019
Merged
busbey added a commit that referenced this pull request Jun 4, 2019
@busbey
[core] add missing license headers. (#1313)
bafc4de 
* #1249 missed headers when moving things out of Client.java
* #1242 missed header on a properties file is added
* #1286 missed header on the new pom file
@busbey busbey mentioned this pull request Jun 4, 2019
Closed
@HoboChen
Copy link
Contributor Author

HoboChen commented Jun 4, 2019

Thank you for your work!

@busbey busbey mentioned this pull request Sep 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busbey busbey busbey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HoboChen @busbey @stfeng2