-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Cosmos [DB] #1264
Azure Cosmos [DB] #1264
Conversation
Still some improvements to make like automatically creating the YCSB database and usertable collection. But this does bring in the all the latest SDKs / etc.
azurecosmos/src/main/java/com/yahoo/ycsb/db/AzureCosmosClient.java
Outdated
Show resolved
Hide resolved
azurecosmos/src/main/java/com/yahoo/ycsb/db/AzureCosmosClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, some minor comments there. PTAL.
@stfeng2 - Thanks for doing the review! |
@voellm - Thanks for contributing to the repo! It's great to have Azure Cosmos DB functionality in YCSB. In the next few days/weeks/months, there will likely be a YCSB release containing your code. As part of the release process, the release master will likely ping you to do some validation and ask you to sign off on the Cosmos DB part of the released binary. Please be on the look for that request for collaboration email when that happens. Thanks! |
This driver is adding full support for Azure Cosmos [DB[ using the latest 2.0 SDK and features.
Planned future work is to auto create the database & collection.
There is an RX driver available for Cosmos DB but given the threading model of YCSB it is not needed.