[travis] drop deprecated oracle JDKs, add openjdk versions for jdk8 and jdk11 #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mind taking a look here @bimargulies-google? |
risdenk
approved these changes
Nov 8, 2018
|
Not sure we need to test both oracle and openjdk especially for JDK 11. |
|
oracle jdk 11 and openjdk 11 in theory are the exact same code base now just which binary gets produced changes. |
|
Yeah, I know in theory. :) I figured a brief period of overlap for testing would shake out any obvious differences. say maybe a month or so? |
|
:) Understand the logic no worries from me |
|
I was on a class all day; sorry, I'll be more responsive in the future.
…On Thu, Nov 8, 2018 at 9:35 AM Sean Busbey ***@***.***> wrote:
mind taking a look here @bimargulies-google
<https://github.com/bimargulies-google>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1253 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AX8h5XgpsvWkcceX5w7EqyQP_WeTFpfQks5utGtfgaJpZM4YUyjW>
.
--
Benson Margulies
|
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we'll try running openjdk an oraclejdk in parallel for a bit, and we don't see any differences just switch to openjdk entirely.