[core] Optimize toArray of all ByteIterators except RandomByteIterator #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manolama
previously requested changes
Mar 19, 2018
| @@ -56,16 +56,6 @@ public Byte next() { | |||
|
|
|||
| public abstract byte nextByte(); | |||
|
|
|||
| /** @return byte offset immediately after the last valid byte */ | |||
| public int nextBuf(byte[] buf, int bufOff) { | |||
There was a problem hiding this comment.
Keep these around since a private DB implementation may rely on it.
| @@ -73,8 +73,7 @@ public byte nextByte() { | |||
| return buf[bufOff - 1]; | |||
| } | |||
|
|
|||
| @Override | |||
| public int nextBuf(byte[] buffer, int bufOffset) { | |||
| private int nextBuf(byte[] buffer, int bufOffset) { | |||
There was a problem hiding this comment.
Keep it public please as mentioned above.
isopov
force-pushed
the
byte-iterators
branch
2 times, most recently
from
dcf6a15
to
7ec7b76
Compare
Method nextBuf is a clever hack that outperforms Random.nextBytes but performs poorly for all other ByteIterator implementations This commit moves it to RandomByteIterator and adds efficient toArray implementations for other ByteIterator classes. Also InputStreamByteIterator.reset method that unconditionally throws UnsupportedOperationException is fixed
isopov
changed the title
|
It looks to me as if all the requested changes were addressed. |
busbey
approved these changes
Apr 26, 2019
There was a problem hiding this comment.
I agree all the feedback was addressed. this looks fine at doing what it says on the tin. Reviewing the toArray added to StringByteIterator I've realized the class is wrong before and after this patch. it drops the upper 8 bits of every character in the string. something for follow-on I think, it's been around for a while.
busbey
dismissed
manolama’s stale review
all feedback was addressed. requested methods were left in place.
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method nextBuf is a clever hack that outperforms Random.nextBytes
but performs poorly for all other ByteIterator implementations
This commit moves it to RandomByteIterator and adds efficient
toArray implementations for other ByteIterator classes.
Also InputStreamByteIterator.reset method that unconditionally
throws UnsupportedOperationException is fixed
Benchmarks for this change is available at https://github.com/isopov/isopov-jmh/blob/master/src/main/java/com/sopovs/moradanen/jmh/ycsb/ByteIteratorBenchmark.java