Switch Accumulo into multiple modules, one per minor release #1034
Conversation
|
ugh. only jdk9 build passed on travis. big frowns. |
busbey
force-pushed
the
accumulo-modules
branch
2 times, most recently
from
9031342
to
67273b3
Compare
|
@madrob, @joshelser can I get a review? |
There was a problem hiding this comment.
You're future-proofing here, Sean? Not trying to work around some active defect between 1.6, 1.7, and 1.8 compatibility? Last I tried, I could use a 1.6 client against all other released versions.
Assuming that's the case: a couple of minor corrections to make, but +1 otherwise
| @@ -0,0 +1,44 @@ | |||
| # Copyright 2014 Cloudera, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
must be from before we switched to the "YCSB contributors" language. not sure if copying it into a new directory is a creative act worthy of updating though.
accumulo1.8/README.md
Outdated
|
|
||
| ### 1. Start Accumulo | ||
|
|
||
| See the [Accumulo Documentation](https://accumulo.apache.org/1.7/accumulo_user_manual.html#_installation) |
There was a problem hiding this comment.
Update for the 1.8 user manual?
|
yeah, future proofing. I figure this will make it easier to compare perf using the 1.6 - 1.8 clients, but I have no specific reason to think they'll be different. |
…minor version specific bindings. * break out accumulo modules * add deprecation warning * switch travis to use short hostname to get around long hostname error.
busbey
force-pushed
the
accumulo-modules
branch
from
67273b3
to
f31b233
Compare
|
I pushed an update that switched the 1.8 and 1.6 specific bindings to both refer to their respective version's user manual. |
|
planning to push this based on @joshelser's previous +1 later today. speak up if anyone would like more time to review further. |
|
+1 from me. Thanks Sean. Nice work here. |
No description provided.