Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spinner fills console with WWWW in JetBrains console. #110

Closed
fredliang44 opened this issue Jan 9, 2021 · 8 comments · Fixed by #115 or kastenhq/kubestr#106
Closed

spinner fills console with WWWW in JetBrains console. #110

fredliang44 opened this issue Jan 9, 2021 · 8 comments · Fixed by #115 or kastenhq/kubestr#106

Comments

@fredliang44
Copy link

As I started spinner in Goland, spinner fills console with WWWW.

CleanShot.2021-01-09.at.12.24.54.mp4
@fredliang44
Copy link
Author

But if I started command from iTerm, the problem no longer appears.

@alx4j
Copy link

alx4j commented Jan 12, 2021

Same issue, problem exists for standard Windows terminal since v1.12.0. Rollback to v1.11.1 helps. For macOS iTerm - no problems.

@briandowns
Copy link
Owner

Hmmm, I wonder what the possible commonality between the Goland terminal and the Windows terminal is? I'll checkout a differ between the two releases to see if I see anything obvious. Thanks for reporting this.

@Jaeyo
Copy link

Jaeyo commented Jan 20, 2021

same problem on windows putty terminal. I also rollback to v1.11.1 and resolved.

@akshaybabloo
Copy link

Any update on this?

@2000Slash
Copy link

Just encountered this on Linux with zsh shell. But only for one line that was longer than my terminal width and had to be wrapped around.

@Dreamacro
Copy link
Contributor

@briandowns
Here's the root cause:

spinner/spinner.go

Lines 399 to 401 in 2cb1a33

for _, c := range []string{"\b", "\127", "\b", "\033[K"} { // "\033[K" for macOS Terminal
fmt.Fprint(s.Writer, strings.Repeat(c, n))
}

I tried removing this code and it still works fine on macOS iterm2, Terminal, JetBrains terminal and vscode's terminal. I'm not sure what this compatibility is for, maybe a historical reason?

@briandowns
Copy link
Owner

Thanks @Dreamacro . Would it be possible to open a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants