Skip to content

Show stoper bug do to parseInt #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Dec 11, 2010
Merged

Show stoper bug do to parseInt #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0249d60
fixed bug related to parseInt bug, leading 0 is interpreated in a fuc…
bjornblomqvist Dec 11, 2010
8ba010b
fixed bug related to parseInt bug, leading 0 is interpreated in a fuc…
bjornblomqvist Dec 11, 2010
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lib/query.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,15 +170,16 @@ var dateParser = function(isoDate) {
var match = dateMatcher.exec(date);
var splitDate = date.split('-');
var year = match[1];
var month = parseInt(match[2])-1;
var month = parseInt(match[2],10)-1;
var day = match[3];

var splitTime = time.split(':');
var hour = parseInt(splitTime[0]);
var min = splitTime[1];
var hour = parseInt(splitTime[0],10);
var min = parseInt(splitTime[1],10);
var end = splitTime[2];
var seconds = /(\d{2})/.exec(end);
seconds = (seconds ? seconds[1] : 0);
seconds = parseInt(seconds,10);
var mili = /\.(\d{1,})/.exec(end);
mili = mili ? mili[1].slice(0,3) : 0;
var tZone = /([Z|+\-])(\d{2})?(\d{2})?/.exec(end);
Expand All @@ -189,10 +190,10 @@ var dateParser = function(isoDate) {
switch(type) {
case 'Z': break;
case '-':
tzAdjust = -(((parseInt(tZone[2])*60)+(parseInt(tZone[3]||0))));
tzAdjust = -(((parseInt(tZone[2],10)*60)+(parseInt(tZone[3]||0,10))));
break;
case '+':
tzAdjust = (((parseInt(tZone[2])*60)+(parseInt(tZone[3]||0))));
tzAdjust = (((parseInt(tZone[2],10)*60)+(parseInt(tZone[3]||0,10))));
break;
default:
throw new Error("Unidentifed tZone part " + type);
Expand All @@ -205,6 +206,9 @@ var dateParser = function(isoDate) {
return date;
};

// To help we test dateParser
Query.dateParser = dateParser;

var dataTypeParsers = {
20: parseInt,
21: parseInt,
Expand Down
7 changes: 7 additions & 0 deletions test/unit/client/query-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
var helper = require(__dirname + '/test-helper');
var q = require('query')

test("testing dateParser", function() {
assert.equal(q.dateParser("2010-12-11 09:09:04").toUTCString(),new Date("2010-12-11 09:09:04 GMT").toUTCString());
});