-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore (ci): add node v20 to build matrix #3148
Conversation
Appreciate your thought here! This got added on another PR actually...but thank you! sorry for the delay ❤️ |
Oopps! My bad - it actually did not get added. I can add it if you want. Otherwise you'll need to rebase here and pick up the fixes that were done on master to make CI pass. 😅 |
@brianc 👍 should be fixed |
Hmm failing no node 20:
|
Adding |
On failing builds, working
broken
|
pg-native build fails on node 20; perhaps that is related. Ref:
Maybe related to #2955? |
Doh! Looks like node-libpq isn't compiling on node 20. Makes sense...I'll see about updating that lib as soon as I'm out of my current job & get more time to really pour some fire on this project!! For now, we'll just skip the native version in CI - really appreciate you! ❤️ |
Per https://nodejs.org/en/about/previous-releases, node v20 is "active".
pg-native
tests are skipped on Node 20 TODO because pg-native doesn't support node 20?