feat(pg-connection-string): ClientConfig helper functions #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will rebase once #3122 lands |
hjr3
force-pushed
the
client-config-compat
branch
from
2289d1a to
385cea3
Compare
| const config = parse('socket:/some path/?db=my[db]&encoding=utf8&client_encoding=bogus') | ||
| const clientConfig = toClientConfig(config) | ||
| clientConfig.host.should.equal('/some path/') | ||
| clientConfig.database.should.equal('my[db]', 'must to be escaped and unescaped through "my%5Bdb%5D"') |
There was a problem hiding this comment.
This feels like it should've thrown an error?
There was a problem hiding this comment.
this is current behavior according to:
hjr3
force-pushed
the
client-config-compat
branch
3 times, most recently
from
c6e6a6f to
1b318dc
Compare
Two new functions are introduced to make it easy for TypeScript users to use a PostgresSQL connection string with pg Client. Fixes brianc#2280
hjr3
force-pushed
the
client-config-compat
branch
from
1b318dc to
9c0560a
Compare
|
@charmander please review this when you have a moment. This is related to #2709 |
|
@brianc what can we do to land |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new functions are introduced to make it easy for TypeScript users to use a PostgresSQL connection string with pg Client.
Fixes #2280