Use 'self.activeQuery' insead of 'this.activeQuery' in readyForQueue #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eue event listener.
brianc
added a commit
that referenced
this pull request
May 8, 2012
Use 'self.activeQuery' insead of 'this.activeQuery' in readyForQueue
Owner
|
I'll version bump tonight after work |
Contributor
Author
|
Wow, 2 minutes? Now that's service! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When client.connect is called, 'self' is assigned the client object, a connection is established, a number of event listeners are added to the connection. In all of those listeners, self was always used except for a single 'this.activeQuery' in the 'readyForQueue' listener.
I was running into a strange issue where handleRowDescription was getting called from a null activeQuery, crashing the application. Unfortunately, I was not able to isolate the exact circumstances in testing, as it only happened sporadically under production load.
Noticing the inconsistency in self/this usage, and assuming it was an error, I changed the readyForQueue listner to use self.activeQuery instead of this.activeQuery. Since that change, I have not had any more problems.
All tests still pass.