update postgres-array to v2 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds engine to match pg and postgres-array
|
Hey @brianc, just wanted to check on this one if you have a sec |
brianc
approved these changes
Jan 8, 2019
| - '4' | ||
| - 'lts/*' |
There was a problem hiding this comment.
this is nice - I didn't know about this
Absolutely, I have 2FA on as a user. I think somewhat recently npm also added the following: That means even a user must configure/pass 2FA even if it's not on at their account level. https://docs.npmjs.com/requiring-2fa-for-package-publishing-and-settings-modification |
|
awesomeness! whats yer npm username - will add you right myeah. |
|
bendrucker |
|
added you! |
|
Published as 2.0, will send a PR to pg |
|
💃
…On Tue, Jan 8, 2019 at 3:16 PM Ben Drucker ***@***.***> wrote:
Published as 2.0, will send a PR to pg
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#76 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADDoSCmG5qDB95FuVTG8BDpUDH6oGIfks5vBQrCgaJpZM4Xz5tx>
.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for handling array dimensions (by discarding) in bendrucker/postgres-array#6
I've added an engine here to match pg and postgres-array and updated Travis to match. This should be published as a major version to be safe. Then pg can just get a patch update that makes the update to types.
@brianc I don't have publish rights on this package (or pg), let me know if you'd rather add me or publish yourself