Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency improvements for tyro.MISSING #264

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Conversation

brentyi
Copy link
Owner

@brentyi brentyi commented Feb 22, 2025

  • More consistent behavior when tyro.MISSING is placed in dataclass definitions
    • Missing semantics were not correctly propagating to children
  • More consistent behavior when tyro.MISSING is used inside of struct types
    • For example: field: tuple[DataclassA, DataclassB] = (tyro.MISSING, tyro.MISSING)
    • This was previously throwing an error

@brentyi brentyi changed the title Minor consistency improvements for tyro.MISSING Consistency improvements for tyro.MISSING Feb 22, 2025
@brentyi brentyi merged commit 5d7aef1 into main Feb 22, 2025
15 checks passed
@brentyi brentyi deleted the brent/improve_tyro_missing branch February 22, 2025 09:41
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.86%. Comparing base (fd876ed) to head (e98e857).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          28       28           
  Lines        2250     2251    +1     
=======================================
+ Hits         2247     2248    +1     
  Misses          3        3           
Flag Coverage Δ
unittests 99.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant