Create Files trait #164
Create Files trait #164
Conversation
|
I'm not sure if this API would support people who wanted custom line-numbers - see #157. |
| column: column_index, | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
This would need to have a number() method to support #157.
| "{origin}:{line}:{column}", | ||
| origin = self.origin, | ||
| line = self.location.line + 1, | ||
| column = self.location.column + 1, |
There was a problem hiding this comment.
This would need to use the proposed number() API to support #157.
brendanzab
force-pushed
the
files-trait
branch
from
c06bedc
to
1a68b22
Compare
|
So yeah, this doesn't actually fix #157, but I think I'll merge it nonetheless, as it's still helpful! |
My concern wasn't that it doesn't fix #157, but rather that it doesn't allow fixing #157, because there's no way to ask the |
|
Ahh, sorry, wouldn't have merged if you were that worried! I'm definitely happy if we alter the |
This will allow clients of
codespan-reportingto implement their own file databases. This is important if we want to allow users to work with frameworks like Salsa, or have domain-specific concerns with regard to file handling.Closes #79.