don't use dart.library.js for conditional import

brendan-duncan · Feb 12, 2025 · 0a95bc7 · 0a95bc7
1 parent 4f151c2
commit 0a95bc7
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 23 deletions.
diff --git a/lib/src/command/executor.dart b/lib/src/command/executor.dart
@@ -1,3 +1 @@
-export '_executor.dart'
-    if (dart.library.io) '_executor_io.dart'
-    if (dart.library.js) '_executor_html.dart';
+export '_executor_html.dart' if (dart.library.io) '_executor_io.dart';
diff --git a/lib/src/formats/jpeg/jpeg_data.dart b/lib/src/formats/jpeg/jpeg_data.dart
@@ -7,15 +7,13 @@ import '../../util/image_exception.dart';
 import '../../util/input_buffer.dart';
 import '_component_data.dart';
 import '_jpeg_huffman.dart';
+import '_jpeg_quantize_html.dart' if (dart.library.io) '_jpeg_quantize_io.dart';
 import 'jpeg_adobe.dart';
 import 'jpeg_component.dart';
 import 'jpeg_frame.dart';
 import 'jpeg_info.dart';
 import 'jpeg_jfif.dart';
 import 'jpeg_marker.dart';
-import 'jpeg_quantize_stub.dart'
-    if (dart.library.io) '_jpeg_quantize_io.dart'
-    if (dart.library.js) '_jpeg_quantize_html.dart';
 import 'jpeg_scan.dart';
 
 @internal

diff --git a/lib/src/transform/resize.dart b/lib/src/transform/resize.dart
@@ -9,10 +9,10 @@ import 'copy_resize.dart';
 
 Image resize(Image src,
     {int? width,
-      int? height,
-      bool? maintainAspect,
-      Color? backgroundColor,
-      Interpolation interpolation = Interpolation.nearest}) {
+    int? height,
+    bool? maintainAspect,
+    Color? backgroundColor,
+    Interpolation interpolation = Interpolation.nearest}) {
   if (width == null && height == null) {
     throw ImageException('Invalid size');
   }
@@ -75,8 +75,11 @@ Image resize(Image src,
   }
 
   if ((width * height) > (src.width * src.height)) {
-    return copyResize(src, width: width, height: height,
-        maintainAspect: maintainAspect, backgroundColor: backgroundColor,
+    return copyResize(src,
+        width: width,
+        height: height,
+        maintainAspect: maintainAspect,
+        backgroundColor: backgroundColor,
         interpolation: interpolation);
   }
 

diff --git a/lib/src/util/file_access.dart b/lib/src/util/file_access.dart
@@ -1,3 +1 @@
-export '_file_access.dart'
-    if (dart.library.io) '_file_access_io.dart'
-    if (dart.library.js) '_file_access_html.dart';
+export '_file_access_html.dart' if (dart.library.io) '_file_access_io.dart';
diff --git a/test/transform/resize_test.dart b/test/transform/resize_test.dart
@@ -20,8 +20,7 @@ void main() {
     test('resize average', () {
       final img =
           decodePng(File('test/_data/png/buck_24.png').readAsBytesSync())!;
-      final i0 =
-          resize(img, width: 64, interpolation: Interpolation.average);
+      final i0 = resize(img, width: 64, interpolation: Interpolation.average);
       expect(i0.width, equals(64));
       expect(i0.height, equals(40));
       File('$testOutputPath/transform/resize_average.png')
@@ -32,8 +31,7 @@ void main() {
     test('resize linear', () {
       final img =
           decodePng(File('test/_data/png/buck_24.png').readAsBytesSync())!;
-      final i0 =
-          resize(img, width: 64, interpolation: Interpolation.linear);
+      final i0 = resize(img, width: 64, interpolation: Interpolation.linear);
       expect(i0.width, equals(64));
       expect(i0.height, equals(40));
       File('$testOutputPath/transform/resize_linear.png')
@@ -168,10 +166,8 @@ void main() {
 
     test('resize palette', () async {
       final img = await decodePngFile('test/_data/png/test.png');
-      final i0 =
-          resize(img!, width: 64, interpolation: Interpolation.cubic);
-      await encodePngFile(
-          '$testOutputPath/transform/resize_palette.png', i0);
+      final i0 = resize(img!, width: 64, interpolation: Interpolation.cubic);
+      await encodePngFile('$testOutputPath/transform/resize_palette.png', i0);
     });
   });
 }