feat: improve rune scan #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVilgelm
reviewed
Nov 2, 2021
Owner
|
I just executed the tests on this PR and they do not pass. |
|
so, what is wrong? could you show some details? |
breml
reviewed
Nov 2, 2021
pkg/bidichk/bidichk.go
Outdated
| pass.Reportf(pos+token.Pos(start), "found dangerous unicode character sequence %s", name) | ||
| start += utf8.RuneLen(r) | ||
| start += idx + utf8.RuneLen(r) | ||
| pass.Reportf(pos+token.Pos(idx), "found dangerous unicode character sequence %s", name) |
Owner
There was a problem hiding this comment.
token.Pos(idx) is wrong, because idx is the position from the last occurrence and not from the beginning of the file.
There was a problem hiding this comment.
oh yeah, sorry, last suggestion was incorrect
ldez
force-pushed
the
fix/improvements
branch
from
3d7d904 to
d73ee04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golangci/golangci-lint#2330 (comment)
Ping @SVilgelm