Repository navigation
#238 — latte ov-tooltip AA stand-in + guard extension to .ov-key - #280
Conversation
The all-theme 50% accent mix for .ov-tooltip .ov-key lands 3.69:1 on latte's #4c4f69 tooltip fill (WCAG AA floor 4.5:1) — the accent-family dark-fill surface the #273 token matrix never measured. Add the latte-scoped 35% stand-in (the symmetric twin of #233 D4's .ct-key repair; measured 4.76 PASS, 40% still fails at 4.38) and extend the AA guard family with ov_tooltip_ov_key_meets_aa_contrast_on_every_theme: canvas-normalized color-mix fg, alpha-composited effective backdrop, transition kill, checkVisibility hygiene, through the real showOvTip reveal path. RED-proven: the guard fails latte = 3.69 on the unfixed CSS. Goldens regenerated per the example-report-check recipes (the only delta is the new rule); jaffle chrome snapshot re-accepted. Closes #238 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 11 minutes and 30 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Ready to review this PR? Stage has broken it down into 4 individual chapters for you:
Chapters generated by Stage for commit 102b32a on Jun 12, 2026 4:41am UTC. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request resolves a WCAG AA contrast ratio issue on the 'latte' theme by adjusting the color mix of .ov-tooltip .ov-key and associated code elements from 50% to 35% accent mix. A new headless integration test, ov_tooltip_ov_key_meets_aa_contrast_on_every_theme, has been added to verify the contrast ratios across all eight themes, and the integration test snapshot has been updated accordingly. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
📄 Rendered report previewAll golden examples regenerated cleanly. 🟡 Golden examplesCommitted to
🐶 Live dogfood previewThis PR doesn't touch ▶ Open ↗ opens the report in your browser in one click — The Pages preview may take ~1 min to update after this comment Alternative: GitHub CLI# gh CLI >= 2.63 extracts into ./report-preview-playground/.
gh run download 27394957263 -R breezy-bays-labs/cute-dbt -n report-preview-playground
open report-preview-playground/playground-report.htmlPosted by |
Overnight orchestration wrap-upMerged as What shipped: the latte-scoped 35% accent stand-in for Story for the morning: #238 was queued as a re-measure after the #251 token repair; the measurement (this issue's earlier comment) showed the hypothesis was false — accent-family in the dark tooltip fill, not muted — and that #273 had nudged it slightly worse. The measured repair landed within the same overnight run, with the guard extension that would have caught the regression direction. 🤖 Generated with Claude Code |
1 participant
Summary
.ov-tooltip .ov-key(the overrides-tooltip key text) ships an all-themecolor-mix(in oklab, var(--accent) 50%, white)inside the always-dark--tooltip-bgfill. On latte (the lightest fill of the 8,#4c4f69, with the light themes' darkest accent — deepened further by #273 for light-page surfaces) that mix measures 3.69:1, below the WCAG AA 4.5:1 floor. This is the accent family's dark-fill surface the #273 token matrix never measured.The fix
The symmetric twin of #233 D4's
.ct-keylatte stand-in: a latte-scoped 35% mix intemplates/report.css, leaving the other 7 themes' 50% mix pinned.Measured before/after (8-theme sweep, alpha-composited effective backdrop, real
showOvTipreveal path)fbdcf86)35% measures 4.76 PASS exactly as the issue's measurement predicted (40% still fails at 4.38).
RED-proof
The new guard
ov_tooltip_ov_key_meets_aa_contrast_on_every_theme(tests/headless_toggle.rs) was run against the unfixed CSS first and failed exactly on latte:With the fix it passes all 8 themes. Guard methodology follows the family: the #233 sweep's canvas-normalized
color-mixfg + the #273 matrix's alpha-composited effective backdrop, transition kill,checkVisibilityhygiene, and the realshowOvTipreveal (focusing theoverrides · Nbadge — keyboard parity), with the bg==tipbg methodology pin.Goldens
report.cssis inlined, so all golden examples were regenerated per theexample-report-checkrecipes (jaffle-shop, playground, diff-showcase; the explore pages are byte-identical — they don't inline report.css).git diff --text -U0 -- examples/audited: the only delta is the new CSS rule + comment. The jaffle chrome insta snapshot re-accepted with the same single-rule delta.Gates (run directly — fresh-worktree lefthook skip rule)
Closes #238
🤖 Generated with Claude Code