Skip to content

[DO NOT MERGE] test: demo — exercise prdiff-preview CI (validation) - #120

Closed
cmbays wants to merge 1 commit into
mainfrom
test-demo-prdiff-preview
Closed

cmbays wants to merge 1 commit into
mainfrom
test-demo-prdiff-preview

Conversation

@cmbays

@cmbays cmbays commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Validation-only — DO NOT MERGE. First real exercise of the prdiff-preview CI job (#118 / PR #119). It should detect this PR touches dbt-project/, install pinned dbt-fusion 2.0.0-preview.177, dbt compile an ephemeral manifest, run cute-dbt --pr-diff on this PR's own dbt-project/ diff, and post a sticky preview comment.

Two deliberate edits, one per diff feature:

The committed dbt-project/target/manifest.json is untouched — CI recompiles ephemerally. Close after the sticky comment is confirmed.

🤖 Generated with Claude Code

…t diff)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@cmbays, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 25 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e47f92fc-764e-4d6d-9a70-4357ff1d6bb4

📥 Commits

Reviewing files that changed from the base of the PR and between a2ecd16 and 203b029.

📒 Files selected for processing (2)
  • dbt-project/models/marts/_marts__models.yml
  • dbt-project/models/marts/order_metrics.sql
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test-demo-prdiff-preview

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates a unit test in _marts__models.yml to use 'Grace Hopper' instead of 'Ada Lovelace' and introduces a new amount_cents column in order_metrics.sql. The reviewer suggested improving the amount_cents column by casting it to an integer to prevent floating-point precision issues, documenting the new column in the schema, and adding it to the unit test expectations.

then round(all_statuses.amount / all_statuses.all_orders_amount, 4)
else 0
end as amount_share,
round(all_statuses.amount * 100, 2) as amount_cents,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Improvement Opportunities for amount_cents

  1. Data Type & Precision: Cents are typically represented as integers. Since amount is a float/double (due to the / 100 division in staging), multiplying by 100 and rounding to 2 decimal places keeps it as a float/double and can introduce floating-point precision issues (e.g., 19.99 becoming 1999.0000000000002). It is safer and more idiomatic to round and cast to an integer.
  2. Schema Documentation: Please remember to document the new amount_cents column in dbt-project/models/marts/_marts__models.yml under the columns section of the order_metrics model.
  3. Unit Test Coverage: Consider adding amount_cents to the expect block of the test_order_metrics_computes_amount_share unit test in _marts__models.yml to ensure its computation is verified.
        cast(round(all_statuses.amount * 100) as integer) as amount_cents,
References
  1. In DuckDB-specific dbt projects, do not replace integer division (e.g., / 100) with float division (e.g., / 100.0) to prevent truncation, as DuckDB performs true division by default.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

📄 Rendered report preview

All examples regenerated cleanly.

This PR touches dbt-project/ — the dbt-project (PrDiff) row below renders this PR's own --pr-diff diff.

Preview Artifact
dbt-project (PrDiff — this PR's own changes) — dbt-project-report.html Download
jaffle-shop — jaffle-shop-report.html Download
playground — playground-report.html Download

Click Download to fetch the rendered HTML. Each artifact
is a zip containing the single-file report — extract and open
in any browser. Reports are fully self-contained (zero
external resource requests).

Alternative: GitHub CLI
# gh CLI >= 2.63 extracts into ./report-preview-playground/.
gh run download 26731507876 -R breezy-bays-labs/cute-dbt -n report-preview-playground
open report-preview-playground/playground-report.html

Posted by report-preview.yml for 203b0299441ee6922829c81bff40f4d6941f4491. Affordance only — never blocks merge.

@cmbays

cmbays commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

Validation demo — purpose served. This throwaway PR was the first real render exercising both diff drawers; it surfaced the double-render bug (#121), now fixed and merged in #122. Closing without merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant