Add Spanish initial support #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademar111190
commented
Nov 2, 2021
| @@ -23,7 +24,7 @@ class BreezDateUtils { | |||
|
|
|||
| static String formatTimelineRelative(DateTime d) { | |||
| if (DateTime.now().subtract(Duration(days: 4)).isBefore(d)) { | |||
| return timeago.format(d, locale: Platform.localeName); | |||
| return timeago.format(d, locale: getSystemLocale().languageCode); | |||
There was a problem hiding this comment.
Using just the language code to avoid default "English" translations if the locale doesn't match language and code.
e.g:
es_MX should use es instead of en.
pt_AO should use pt instead of en.
ademar111190
commented
Nov 2, 2021
| @@ -40,8 +41,7 @@ class BreezDateUtils { | |||
|
|
|||
| static void setupLocales() { | |||
| timeago.setLocaleMessages('en', timeago.EnMessages()); | |||
| timeago.setLocaleMessages('en_short', timeago.EnShortMessages()); | |||
There was a problem hiding this comment.
Removing short messages as we do not use it yet.
ademar111190
commented
Nov 2, 2021
| <string>pt</string> | ||
| <string>de</string> |
There was a problem hiding this comment.
Forget to remove de translation from ios, related: #614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking texts already added to l10n from the Going Global PR #464 Spanish translation
How it looks like