Improve Button type definitions#42
Merged
fallaciousreasoning merged 4 commits intomainfrom Nov 14, 2022
Merged
Conversation
d8454af to
0827d0c
Compare
Collaborator
Author
|
Hey @AlanBreck do we want to try and land this? |
Collaborator
|
Sounds good to me!! |
73d13e2 to
289188d
Compare
Collaborator
Author
|
All right, I've fixed the merge conflict and the formatting. Anything else need doing? |
Collaborator
|
Not that I can think of. The only thing that would be nice in the future is if there's any opportunity to simply for future component authors. No idea how, though. 😂 |
Collaborator
Author
|
Yeah, It's definitely pretty awkward at the moment - hopefully Svelte improves this :D |
Collaborator
Author
|
@petemill what are your thoughts on this? |
289188d to
bef57e7
Compare
0ab800c to
8c026db
Compare
AlanBreck
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does the following:
It does not:
@petemill what do you think about this as an approach?