Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Allows for custom publisher logo in donationOverlay #327

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Dec 20, 2018

Related: brave/brave-browser#2668

Changes

Adds support custom publisher logo in the donationOverlay component. Implementation and styling is similar to how it is in siteBanner.

Test plan

Please view the donationOverlay concept in Rewards > Other in the provided storybook (https://brave-ui-4ty18cf5o.now.sh)

This is the knob configuration for getting the custom logo to show:

screen shot 2018-12-20 at 11 47 52 am

Preview:
screen shot 2018-12-20 at 11 52 34 am

Link / storybook path to visual changes

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)
  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.60.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@ryanml ryanml merged commit 2b5fb2e into brave:master Dec 21, 2018
@ryanml ryanml deleted the fix-2668 branch December 21, 2018 14:03
ryanml added a commit to ryanml/brave-ui that referenced this pull request Dec 23, 2018
Allows for custom publisher logo in donationOverlay
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants