Properly get tab origin for brave shields.

[iefremov]

see also #5925

Fixes brave/brave-browser#16265

Resolves

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[antonok-edm]

Just checked, this works on my build with the https://mybroadband.co.za/news/energy/400329-koeberg-nuclear-power-station-manager-suspended.html test case 👍

[mariospr]

LGTM with a small coment

[mariospr]

It seems like you can completely remove BraveShieldsWebContentsObserver::GetTabURLFromRenderFrameInfo() from the repository now, since this was apparently the only caller.

[kjozwiak]

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.27.51 Chromium: 91.0.4472.88 (Official Build) nightly (64-bit)
--- | ---
Revision | 109e9cd038b94a631aea7d40ee3d56c1278f2597-refs/branch-heads/4472@{#1385}
OS | Windows 10 OS Version 2009 (Build 19042.1023)

Test Case #1 (Original issue mentioned via )

• load https://www.tecmint.com and disable shields
• open the dev tools and select Network
• refresh the page
• ensure that none of the requests are Status: (blocked:)

1.25.70 Chromium: 91.0.4472.77	1.27.51 Chromium: 91.0.4472.88

Test Case #2

• visit https://www.google.ca & searched for under armour
• ensure that ads are being displayed as Trackers & ads blocking is set as standard via brave://settings/shields by default
• change Trackers & ads blocking to aggressive via the shields panel and ensure that the tab refreshes and ads are not being displayed
• change Trackers & ads blocking to Disabled via brave://settings/shields and ensure that Trackers & ads blocking is still set aggressive under https://www.google.ca

Test Case #3

• visit https://www.blizzard.com and ensure that Block scripts is disabled and the page loads without any issues
• enable Block scripts using the shields panel and ensure that scripts are being blocked once the tab is automatically refreshed

Test Case #4

• visit http://https-everywhere.badssl.com and disable HTTPS from the shields panel
• visit http://https-everywhere.badssl.com again and ensure that the HTTPS upgrade doesn't occur

Test Case #5

• visit https://jsfiddle.net/7ke9r14a/9 and change Cookie blocking to All cookies allowed
• ensure that the Results area under https://jsfiddle.net/7ke9r14a/9 displays something similar

local storage:
"00"
session storage:
"00"
indexeddb:
cookies:
""
websql:
{"0":{"tbl_name":"__WebKitDatabaseInfoTable__"},"1":{"tbl_name":"todo"}}
filesystem API:
"https_fiddle.jshell.net_0:Persistent"

• change Cookie blocking to Cookies blocked and ensure that https://jsfiddle.net/7ke9r14a/9 never laods

Test Case #6

Run through https://dev-pages.brave.software/fingerprinting/farbling.html