Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13778: Avoid crash while getting an accessibility string. (uplift to 1.19.x) #7735

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 28, 2021

Uplift of #7708
Fix brave/brave-browser#13778

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner January 28, 2021 10:52
@brave-builds brave-builds requested a review from a team January 28, 2021 10:52
@brave-builds brave-builds self-assigned this Jan 28, 2021
@brave-builds brave-builds added this to the 1.19.x - Release #2 milestone Jan 28, 2021
@kjozwiak
Copy link
Member

Restarting Win x64 using SKIP_INIT due to dist failing because of a certificate issue as per https://ci.brave.com/job/pr-brave-browser-pr7708_ie_accessibility_2_1.19.x-windows/1/execution/node/226/log/.

08:30:25  Generating code
08:30:25  Finished generating code
08:30:25  Copy("scons-out\opt-win\obj\google_update\BraveUpdate_signed.exe", "scons-out\opt-win\obj\google_update\BraveUpdate_unsigned.exe")
08:30:25  Chmod("scons-out\opt-win\obj\google_update\BraveUpdate_signed.exe", 0755)
08:30:25  python C:\19.x\src\brave\vendor\omaha\omaha/tools/retry.py 10 5 ""C:\Program Files (x86)\Windows Kits\10\bin\10.0.18362.0\\x86"/signtool.exe" sign /v /f "C:\jenkins\digicert.pfx" /p "****" /t "http://timestamp.digicert.com" "scons-out\opt-win\obj\google_update\BraveUpdate_signed.exe"
08:30:25  SignTool Error: No certificates were found that met all the given criteria.

@kjozwiak
Copy link
Member

Win x64 failed dist due to a certificate issue which is a known failure as per https://ci.brave.com/job/pr-brave-browser-pr7708_ie_accessibility_2_1.19.x-windows/1/execution/node/226/log/. However, as per @mihaiplesa, this doesn't block uplift.

08:30:25  Generating code
08:30:25  Finished generating code
08:30:25  Copy("scons-out\opt-win\obj\google_update\BraveUpdate_signed.exe", "scons-out\opt-win\obj\google_update\BraveUpdate_unsigned.exe")
08:30:25  Chmod("scons-out\opt-win\obj\google_update\BraveUpdate_signed.exe", 0755)
08:30:25  python C:\19.x\src\brave\vendor\omaha\omaha/tools/retry.py 10 5 ""C:\Program Files (x86)\Windows Kits\10\bin\10.0.18362.0\\x86"/signtool.exe" sign /v /f "C:\jenkins\digicert.pfx" /p "****" /t "http://timestamp.digicert.com" "scons-out\opt-win\obj\google_update\BraveUpdate_signed.exe"
08:30:25  SignTool Error: No certificates were found that met all the given criteria.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.19.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7708 (comment) and created brave/brave-browser#13837 as a follow up.

@kjozwiak kjozwiak merged commit d399a7d into 1.19.x Jan 29, 2021
@kjozwiak kjozwiak deleted the pr7708_ie_accessibility_2_1.19.x branch January 29, 2021 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants