Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for crash in CanvasAsyncBlobCreator #6320

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Aug 3, 2020

Resolves brave/brave-browser#10913

This is not a long-term solution for reasons discussed in Slack but it avoids the crash while manipulating an offscreen canvas.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pilgrim-brave pilgrim-brave self-assigned this Aug 3, 2020
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_canvasasyncblobcreator branch from 2edb4f0 to 4066307 Compare August 3, 2020 15:20
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_canvasasyncblobcreator branch 2 times, most recently from 7727bc3 to 894a93f Compare August 3, 2020 19:52
tests

use DynamicTo instead

lilnt
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_canvasasyncblobcreator branch from 894a93f to a476650 Compare August 3, 2020 21:43
@pilgrim-brave pilgrim-brave merged commit 52b5109 into master Aug 4, 2020
@pilgrim-brave pilgrim-brave deleted the mpilgrim_canvasasyncblobcreator branch August 4, 2020 00:35
@iefremov
Copy link
Contributor

iefremov commented Aug 4, 2020

This actually fixes another issue brave/brave-browser#10913

@pilgrim-brave do you think this is a same problem? It seems to me checking for non-zero TopFrameOrigin() in https://github.com/brave/brave-core/blob/master/chromium_src/third_party/blink/renderer/core/dom/document.cc#L31 is also worth doing

@pilgrim-brave
Copy link
Contributor Author

Argh, no, I just mis-linked the resolution bug because I had too many tabs open. I'll fix it.

brave/brave-browser#10914 is a separate problem which I am still investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Crash in CanvasAsyncBlobCreator
3 participants