Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backup notice #5958

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Add backup notice #5958

merged 2 commits into from
Jul 2, 2020

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Jun 26, 2020

Resolves brave/brave-browser#10021

Submitter Checklist:

Test Plan:

  • Clean profile
  • Enable Rewards
  • Restore wallet with user funds
  • Wait for OnFetch callback
  • Click on gear to bring up backup/restore modal
  • Verify that modal text matches spec
  • Verify that clicking the "connect to Uphold" link initiates the Uphold connection process
  • Verify that you can switch back and forth between Backup/Restore tabs

  • Clean profile
  • Enable Rewards
  • Claim promotion
  • Wait for OnFetch callback
  • Click on gear to bring up backup/restore modal
  • "Backup" tab should show text from the spec
  • Verify that clicking the "connect to Uphold" link in the modal notice initiates the Uphold connection process

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 29, 2020

@emerick can we please move text for new users into backup tab, so that we are not stacking dialogs and we are just switching content based on user balance

@emerick emerick force-pushed the rewards-backup-notice branch 4 times, most recently from 1d42470 to 70e3159 Compare June 29, 2020 15:43
@emerick emerick requested a review from zenparsing June 29, 2020 16:22
@NejcZdovc NejcZdovc added this to the 1.12.x - Nightly milestone Jun 29, 2020
@emerick emerick force-pushed the rewards-backup-notice branch 3 times, most recently from a021961 to ba2b72e Compare July 1, 2020 00:08
@emerick emerick requested a review from NejcZdovc July 1, 2020 00:11
@emerick
Copy link
Contributor Author

emerick commented Jul 1, 2020

@NejcZdovc Updated with browser tests but there's one small outstanding issue, see my comment above.

@emerick emerick force-pushed the rewards-backup-notice branch 4 times, most recently from e266ec5 to 5b481bd Compare July 1, 2020 13:51
@emerick
Copy link
Contributor Author

emerick commented Jul 1, 2020

CI had a browser test failure on linux, restarting there. Ignoring test-install failure on Mac.

@emerick
Copy link
Contributor Author

emerick commented Jul 1, 2020

All CI is green now except for previously-noted test-install failure on Mac.

@emerick emerick merged commit 913c5ac into master Jul 2, 2020
@emerick emerick deleted the rewards-backup-notice branch July 2, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants