Fixes Firebase issues brave/brave-browser#10367 brave/brave-browser#9852 #5938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also affecting brave/brave-browser#5075 |
fmarier
requested changes
Jun 25, 2020
There was a problem hiding this comment.
I'd suggest changing the commit message to ensure that the GitHub issues are automatically closed:
Allow Firebase third-party cookies, necessary for the login flow
Fixes brave/brave-browser#5075
Fixes brave/brave-browser#9852
Fixes brave/brave-browser#10367
|
Also, discussing with @bridiver if we should fold this into the google auth toggle. |
|
Closing this in favor of #5952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with sites using firebaseapp, brave/brave-browser#10367 and brave/brave-browser#9852
Probably affecting many other sites using firebase
Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.
Any questions let me know