Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not start process if rewards is off #5924

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Do not start process if rewards is off #5924

merged 1 commit into from
Jun 26, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 23, 2020

Resolves brave/brave-browser#9526

Submitter Checklist:

Test Plan:

  • start browser
  • open task manager
  • make sure that there is no ledger process
  • join rewards
  • make sure that all looks good and you can claim promotions
  • disable rewards
  • open task manager
  • make sure that there is no ledger process
  • toggle on/off and make sure that process is managed correctly

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this Jun 23, 2020
@NejcZdovc NejcZdovc force-pushed the rewards-shutdown branch 2 times, most recently from cec7d69 to 76c21f7 Compare June 23, 2020 15:13
@NejcZdovc NejcZdovc added this to the 1.12.x - Nightly milestone Jun 24, 2020
@NejcZdovc NejcZdovc marked this pull request as ready for review June 24, 2020 10:20
@NejcZdovc NejcZdovc requested a review from tmancey as a code owner June 24, 2020 10:20
@NejcZdovc NejcZdovc requested review from yrliou, a team and emerick and removed request for a team June 24, 2020 10:21
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@zenparsing zenparsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I'd like to understand better why we have the process-supporting infrastructure we have (like the mojo ledger bridge classes, for instance) at some point.

I was a little confused at first about the "startRewards"/"stopRewards" methods in the UI components, since they don't seem to start and stop the service.

@NejcZdovc
Copy link
Contributor Author

@zenparsing happy to explain it

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start shared lib only if rewards is enabled
5 participants