Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: climb frame tree to determine top level eTLD+1 when generating farble seed (uplift to 1.11.x) #5891

Closed
wants to merge 1 commit into from
Closed

WIP: climb frame tree to determine top level eTLD+1 when generating farble seed (uplift to 1.11.x) #5891

wants to merge 1 commit into from

Conversation

bsclifton
Copy link
Member

Uplift of #5877
Fixes brave/brave-browser#10260

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@pes10k @bsclifton
Merge pull request #5877 from brave/change-farbling-origin-lookup
71aff39 
climb frame tree to determine top level eTLD+1 when generating farble seed
@bsclifton bsclifton added this to the 1.11.x - Beta milestone Jun 18, 2020
@bsclifton bsclifton requested a review from a team June 18, 2020 06:10
@bsclifton bsclifton requested a review from bridiver as a code owner June 18, 2020 06:10
@bsclifton bsclifton self-assigned this Jun 18, 2020
@bsclifton bsclifton changed the title climb frame tree to determine top level eTLD+1 when generating farble seed (uplift to 1.11.x) WIP: climb frame tree to determine top level eTLD+1 when generating farble seed (uplift to 1.11.x) Jun 18, 2020
@bsclifton
Copy link
Member Author

Closing in favor of #5902

@bsclifton bsclifton closed this Jun 19, 2020
@bsclifton bsclifton deleted the change-farbling-origin-lookup-1.11.x branch June 19, 2020 06:16
@bsclifton bsclifton removed this from the 1.11.x - Beta milestone Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsclifton @pes10k