Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sony.com cookies on https://store.playstation.com/ #5857

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Jun 16, 2020

Resolves cookie issues between sony.com and store.playstation.com

Submitter Checklist:

Test Plan:

Related to: https://github.com/brave/brave-browser/issues/9987 Missing sony.com domain from https://store.playstation.com/ which is still causing issues. Still causing login issues otherwise.

Exisiting ticket: brave/brave-browser#9987

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

Should be safe for Brave Beta @bsclifton Testing in Brave Beta/Nightly.

@ryanbr ryanbr requested a review from bridiver as a code owner June 16, 2020 11:31
@ryanbr ryanbr changed the title Allow sony.com cookies on https://store.playstation.com/ Allow sony.com cookies on https://store.playstation.com/ and Firebase/google auth issues. Jun 23, 2020
@ryanbr ryanbr changed the title Allow sony.com cookies on https://store.playstation.com/ and Firebase/google auth issues. Allow sony.com cookies on https://store.playstation.com/ Jun 23, 2020
@pes10k pes10k added this to the 1.12.x - Nightly milestone Jun 25, 2020
@pes10k pes10k merged commit 1163d54 into brave:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants