Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement farbling levels for webaudio (uplift to 1.11.x) #5814

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Implement farbling levels for webaudio (uplift to 1.11.x) #5814

merged 1 commit into from
Jun 19, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jun 11, 2020 •
edited by bsclifton
Loading

Uplift of #5794
Resolves brave/brave-browser#9187

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team June 11, 2020 13:46
@brave-builds brave-builds self-assigned this Jun 11, 2020
@brave-builds brave-builds added this to the 1.11.x - Beta milestone Jun 11, 2020
@kjozwiak
Copy link
Member

@pes10k @pilgrim-brave could we some test cases that QA can run through? This will need to get checked on Nightly before it's uplifted into 1.11.x.

@pes10k
Copy link
Contributor

pes10k commented Jun 16, 2020

@kjozwiak one step ahead of ya! I wrote tests for this on https://dev-pages.brave.software/farbling.html and https://dev-pages.bravesoftware.com/farbling.html

bsclifton
bsclifton approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on master and also full build locally (tested along with #5902). Works great!

@bsclifton bsclifton merged commit 6b38495 into 1.11.x Jun 19, 2020
@bsclifton bsclifton deleted the pr5794_mpilgrim_webaudio_v2_1.11.x branch June 19, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.11.x - Release #1
Development

Successfully merging this pull request may close these issues.
5 participants
@brave-builds @kjozwiak @pes10k @bsclifton @brave-browser-releases